Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1 #6792

Merged
merged 3 commits into from
Apr 6, 2016
Merged

Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1 #6792

merged 3 commits into from
Apr 6, 2016

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Apr 5, 2016

No description provided.

@LeeDr
Copy link
Author

LeeDr commented Apr 5, 2016

jenkins, test it

@epixa
Copy link
Contributor

epixa commented Apr 5, 2016

Can you make sure to backport this back as far as is reasonable?

@LeeDr
Copy link
Author

LeeDr commented Apr 5, 2016

Yes @epixa but I might need a bit of help figuring out labels<->branches. I added some labels but probably need some adjustments. But should be easy to backport to every branch.

@tylersmalley
Copy link
Contributor

Do we also need to update https://github.com/elastic/kibana/blob/master/tasks/config/downloadSelenium.js#L4?

@epixa epixa added v4.6.0 and removed v4.5.0 labels Apr 5, 2016
@LeeDr
Copy link
Author

LeeDr commented Apr 5, 2016

I would guess so. I guess the task downloads it and the intern config causes it to try to start that version? Would be nice to define it only in one place. Maybe @jbudz has a suggestion? If not, I'll just update that other file too.

@jbudz
Copy link
Member

jbudz commented Apr 6, 2016

@LeeDr should be fine to move the version to test/server_config.js and reference from from both files. There's precedence for pulling the es/webdriver requests from there for grunt tasks

@epixa
Copy link
Contributor

epixa commented Apr 6, 2016

I think the hash on line 15 of tasks/config/downloadSelenium.js needs to be updated.

@jbudz
Copy link
Member

jbudz commented Apr 6, 2016

👍 hash can be found here https://selenium-release.storage.googleapis.com/index.html?path=2.53/

@LeeDr
Copy link
Author

LeeDr commented Apr 6, 2016

Yep, since the md5 is checked against the download, I'm going to leave the code as it is and just update the versions and md5.

@LeeDr
Copy link
Author

LeeDr commented Apr 6, 2016

Seems to be using this version successfully now;

Downloading https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar...managr    log   [15:50:23.866] [info][status][plugin:elasticsearch] Status changed from yellow to green - Kibana index ready
done
Validating hash...done

>> 0/80 tests failed

@tylersmalley
Copy link
Contributor

Looks good @LeeDr

@tylersmalley tylersmalley assigned LeeDr and unassigned tylersmalley Apr 6, 2016
@LeeDr LeeDr merged commit 53b05e9 into elastic:master Apr 6, 2016
@elastic-jasper elastic-jasper mentioned this pull request Apr 6, 2016
Merged
LeeDr pushed a commit that referenced this pull request Apr 6, 2016
Backport PR #6792
7425979 
---------

**Commit 1:**
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

* Original sha: 81821fc
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-05T20:46:06Z

**Commit 2:**
Update downloadSelenium to match version in intern.js.

* Original sha: 431fe52
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T12:36:06Z

**Commit 3:**
Add selenium-server-standalone jar md5.

* Original sha: 4002140
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T13:46:17Z
elastic-jasper added a commit that referenced this pull request Apr 6, 2016
@elastic-jasper
Backport PR #6792
5bc2539 
---------

**Commit 1:**
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

* Original sha: 81821fc
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-05T20:46:06Z

**Commit 2:**
Update downloadSelenium to match version in intern.js.

* Original sha: 431fe52
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T12:36:06Z

**Commit 3:**
Add selenium-server-standalone jar md5.

* Original sha: 4002140
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T13:46:17Z
@elastic-jasper elastic-jasper mentioned this pull request Apr 6, 2016
Merged
elastic-jasper added a commit that referenced this pull request Apr 6, 2016
@elastic-jasper
Backport PR #6792
c4a0c05 
---------

**Commit 1:**
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

* Original sha: 81821fc
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-05T20:46:06Z

**Commit 2:**
Update downloadSelenium to match version in intern.js.

* Original sha: 431fe52
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T12:36:06Z

**Commit 3:**
Add selenium-server-standalone jar md5.

* Original sha: 4002140
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T13:46:17Z
@elastic-jasper elastic-jasper mentioned this pull request Apr 6, 2016
Merged
elastic-jasper added a commit that referenced this pull request Apr 6, 2016
@elastic-jasper
Backport PR #6792
3a067f6 
---------

**Commit 1:**
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

* Original sha: 81821fc
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-05T20:46:06Z

**Commit 2:**
Update downloadSelenium to match version in intern.js.

* Original sha: 431fe52
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T12:36:06Z

**Commit 3:**
Add selenium-server-standalone jar md5.

* Original sha: 4002140
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T13:46:17Z
@elastic-jasper elastic-jasper mentioned this pull request Apr 6, 2016
Merged
elastic-jasper added a commit that referenced this pull request Apr 6, 2016
@elastic-jasper
Backport PR #6792
3ea9a7e 
---------

**Commit 1:**
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

* Original sha: 81821fc
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-05T20:46:06Z

**Commit 2:**
Update downloadSelenium to match version in intern.js.

* Original sha: 431fe52
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T12:36:06Z

**Commit 3:**
Add selenium-server-standalone jar md5.

* Original sha: 4002140
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T13:46:17Z
@elastic-jasper elastic-jasper mentioned this pull request Apr 6, 2016
Merged
LeeDr pushed a commit that referenced this pull request Apr 6, 2016
Merge pull request #6802 from elastic/jasper/backport/6792/4.x
3a36b4b 
[backport] PR #6792 to 4.x
@LeeDr LeeDr deleted the updateSelenium2.53 branch April 6, 2016 19:17
LeeDr pushed a commit that referenced this pull request Apr 6, 2016
Merge pull request #6806 from elastic/jasper/backport/6792/6802/4.3
ba4bd84 
[backport] PR #6792 to 4.3
LeeDr pushed a commit that referenced this pull request Apr 6, 2016
Merge pull request #6805 from elastic/jasper/backport/6792/6802/4.4
af1035f 
[backport] PR #6792 to 4.4
LeeDr pushed a commit that referenced this pull request Apr 8, 2016
Merge pull request #6804 from elastic/jasper/backport/6792/6802/4.5
4bacb26 
[backport] PR #6792 to 4.5
epixa added a commit that referenced this pull request Apr 15, 2016
@epixa
Merge pull request #6807 from elastic/jasper/backport/6792/6802/4.2
738b2c1 
[backport] PR #6792 to 4.2
@epixa epixa added v4.5.2 and removed v4.5.1 labels May 14, 2016
@epixa epixa added v4.5.4 and removed v4.5.2 labels Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review test v4.2.0 v4.3.0 v4.4.0 v4.5.0 v4.5.4 v4.6.0 v5.0.0-alpha2 v5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeeDr @epixa @tylersmalley @jbudz